----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75055/#review226567 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java Line 40 (original) <https://reviews.apache.org/r/75055/#comment314830> For backward compatibility, existing public members should be retained. @Deprecated annotation/a comment can be added to mark that this member is not used. - Madhan Neethiraj On June 18, 2024, 6:06 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75055/ > ----------------------------------------------------------- > > (Updated June 18, 2024, 6:06 p.m.) > > > Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, and > Ramesh Mani. > > > Bugs: RANGER-4824 > https://issues.apache.org/jira/browse/RANGER-4824 > > > Repository: ranger > > > Description > ------- > > Ranger unit test framework for policy engine functional tests uses two > different types of policy-engines for executing unit tests; one is base on > interpreted model that is used in production and another is based on the ACLs > computed from the set of Ranger policies. As the latter is not used anywhere > other than during unit tests, for the brevity of the code-base, it need not > be used for unit testing and needs be removed from the code. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > f5f412797 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 33d56ec57 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > b62fdfbb6 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > d78084589 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineForDeltas.java > 3e5086cdf > > > Diff: https://reviews.apache.org/r/75055/diff/1/ > > > Testing > ------- > > Compiled and ran all unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
