----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74976/#review226579 -----------------------------------------------------------
Ship it! Ship It! - Dineshkumar Yadav On June 17, 2024, 6:11 a.m., Rakesh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74976/ > ----------------------------------------------------------- > > (Updated June 17, 2024, 6:11 a.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4782 > https://issues.apache.org/jira/browse/RANGER-4782 > > > Repository: ranger > > > Description > ------- > > Implement best coding practices for validating service configs > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java > b9d51602e > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx > 668de52e7 > > > Diff: https://reviews.apache.org/r/74976/diff/5/ > > > Testing > ------- > > Validated Service Connection failed, when using 'localhost' or '127.0.0.1' as > the hostname in the service configuration. > > Tested If a service configuration contains a null value, it won't be added to > the service. > > > Thanks, > > Rakesh Gupta > >
