> On June 21, 2024, 4:22 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java > > Line 209 (original), 210 (patched) > > <https://reviews.apache.org/r/75051/diff/2/?file=2289214#file2289214line210> > > > > Call to remove() will fail if options is an instance of > > Collections.emptyMap(). Please review the previous comment for details to > > handle this case.
Appologies for my oversight. I have updated the patch. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75051/#review226580 ----------------------------------------------------------- On June 25, 2024, 8:06 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75051/ > ----------------------------------------------------------- > > (Updated June 25, 2024, 8:06 a.m.) > > > Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika > Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4822 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4822 > > > Repository: ranger > > > Description > ------- > > Initialising RangerPolicy.options to a modifiable HashMap since it is being > modified when validity period is being added > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java > ad7cdc7f6 > > > Diff: https://reviews.apache.org/r/75051/diff/3/ > > > Testing > ------- > > Validated policy creation and updation > > > Thanks, > > Anand Nadar > >
