-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75078/#review226642
-----------------------------------------------------------


Ship it!




Ship It!

- bhavik patel


On July 9, 2024, 7:46 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75078/
> -----------------------------------------------------------
> 
> (Updated July 9, 2024, 7:46 a.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Bhavik Bavishi, Fateh Singh, 
> Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Mugdha Varadkar, Pradeep 
> Agrawal, Ramesh Mani, Sailaja Polavarapu, Velmurugan Periasamy, and zhongwei 
> wang.
> 
> 
> Bugs: RANGER-4845
>     https://issues.apache.org/jira/browse/RANGER-4845
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - replaced use of following guava classes/pacakges:
>   -- com.google.common.base.Strings =>  org.apache.commons.lang3.StringUtils
> -- com.google.common.base         => 
> org.apache.hadoop.thirdparty.com.google.common.base
> -- com.google.common.collect      => 
> org.apache.hadoop.thirdparty.com.google.common.collect
> -- com.google.common.annotations  => 
> org.apache.hadoop.thirdparty.com.google.common.annotations
> -- com.google.common.util.concurrent.ThreadFactoryBuilder => 
> org.apache.hadoop.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder
> - updated pom files to remove dependency on guava library
> - updated distro to remove packaging of guava library
> 
> 
> Diffs
> -----
> 
>   agents-audit/pom.xml 06e81650f 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java
>  b81c30e51 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
>  51a3aae6f 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
>  9cbea7f61 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java
>  5521146b9 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> f1f2b0920 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  a1df53fac 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcherTest.java
>  ec64e33e4 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java
>  2c69bcc6f 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestDirectedGraph.java
>  3ec20d99a 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java
>  7e16082bc 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefHelper.java
>  b0c108530 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerDefaultResourceMatcherTest.java
>  8a297bde0 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java
>  3727b30d4 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcherTest.java
>  cc7307615 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/util/PasswordUtilsTest.java
>  d0b180645 
>   credentialbuilder/pom.xml 0f61148ee 
>   distro/src/main/assembly/admin-web.xml 0c8afa9d0 
>   distro/src/main/assembly/hbase-agent.xml b36652091 
>   distro/src/main/assembly/hdfs-agent.xml 498b2ff2b 
>   distro/src/main/assembly/hive-agent.xml 17757f90b 
>   distro/src/main/assembly/kms.xml c9b863088 
>   distro/src/main/assembly/knox-agent.xml e97a9c6c8 
>   distro/src/main/assembly/plugin-atlas.xml ed0108475 
>   distro/src/main/assembly/plugin-elasticsearch.xml a627f641b 
>   distro/src/main/assembly/plugin-kafka.xml 782f0ab79 
>   distro/src/main/assembly/plugin-kms.xml 928db2041 
>   distro/src/main/assembly/plugin-kylin.xml 968197a4a 
>   distro/src/main/assembly/plugin-ozone.xml f1b78699c 
>   distro/src/main/assembly/plugin-presto.xml b5fced211 
>   distro/src/main/assembly/plugin-solr.xml fb05fa2af 
>   distro/src/main/assembly/plugin-sqoop.xml 37c1a6f8f 
>   distro/src/main/assembly/plugin-trino.xml a2f4828a4 
>   distro/src/main/assembly/plugin-yarn.xml 9f112dcbf 
>   distro/src/main/assembly/ranger-tools.xml 518615c9b 
>   distro/src/main/assembly/sample-client.xml b7c73ef8b 
>   distro/src/main/assembly/storm-agent.xml 1beb06c96 
>   distro/src/main/assembly/tagsync.xml 616f577f1 
>   distro/src/main/assembly/usersync.xml 7ade67859 
>   hbase-agent/pom.xml 5b4e4313e 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
>  2e8eeafea 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
>  cc9a68f27 
>   
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationFilter.java
>  6e3900a18 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/RangerAuthorizationFilterTest.java
>  e009347b8 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  e226da8a5 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  4ba327337 
>   kms/pom.xml bfac6424a 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 
> 7b5e8bf7b 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java 
> 4f5da6471 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java 
> 281ff4554 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 
> f0ed18309 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java
>  e63154942 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/SimpleKMSAuditLogger.java
>  50a92b507 
>   
> knox-agent/src/test/java/org/apache/ranger/services/knox/RangerAdminClientImpl.java
>  4c51e592e 
>   plugin-atlas/pom.xml ad950f70d 
>   
> plugin-elasticsearch/src/main/java/org/apache/ranger/authorization/elasticsearch/authorizer/RangerElasticsearchAuthorizer.java
>  a09319f63 
>   
> plugin-kms/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java
>  799eb322c 
>   
> plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSClient.java 
> 14e9c3bd1 
>   
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java
>  bcfaaafef 
>   
> plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java
>  53cc0201e 
>   
> plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java
>  ed8c837d5 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/FieldToAttributeMapping.java
>  ba5f7d478 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  e9b053381 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/SubsetQueryPlugin.java
>  1ea4d2843 
>   
> plugin-sqoop/src/main/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizer.java
>  65e08e41b 
>   plugin-trino/pom.xml e4d161417 
>   
> plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
>  de3493eb6 
>   pom.xml 68fc34a72 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 
> 758516a0e 
>   ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java 
> 6ae4a33f7 
>   
> ranger-common-ha/src/main/java/org/apache/ranger/ha/ZookeeperSecurityProperties.java
>  01a034fab 
>   ranger-examples/distro/src/main/assembly/plugin-sampleapp.xml 16f60bc1d 
>   ranger-examples/distro/src/main/assembly/sample-client.xml 681df2f6a 
>   ranger-examples/plugin-sampleapp/pom.xml d9823cd7b 
>   ranger-examples/sample-client/pom.xml e87844acd 
>   ranger-presto-plugin-shim/pom.xml 6cd835b7f 
>   
> ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java
>  e446ada03 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  cef7bd959 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  187d20227 
>   security-admin/pom.xml 5ca5028d9 
>   security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 3adb7794a 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> a8234325b 
>   security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java 
> b5c47d3e9 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> 8f87d26fa 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java
>  29c1bcdef 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  694976d68 
>   
> storm-agent/src/main/java/org/apache/ranger/authorization/storm/StormRangerPlugin.java
>  9cf352880 
>   
> storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java
>  fd42090b1 
>   tagsync/pom.xml a1445fdd8 
>   ugsync/pom.xml 54f793aa3 
>   
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
>  b1a6af183 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java
>  5525305b7 
>   unixauthclient/pom.xml c7fc6f33e 
>   unixauthservice/pom.xml c26738ff6 
> 
> 
> Diff: https://reviews.apache.org/r/75078/diff/1/
> 
> 
> Testing
> -------
> 
> - built successfully with all unit tests
> - using docker setup, verified that services Ranger/Usersync/Tagsync/KMS and 
> plugins HDFS/Hive/HBase/Kafka/YARN/KMS are successfully deployed and working
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to