-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75004/
-----------------------------------------------------------
(Updated July 9, 2024, 12:46 p.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-4795: Add validation in API to check emptiness on policyitem while
creating policy.
Bugs: RANGER-4795
https://issues.apache.org/jira/browse/RANGER-4795
Repository: ranger
Description (updated)
-------
There is an inconsistency between Ranger API and UI not doing the same
validation for Policy creation.
Policy creation API should fail when a policy with all empty values and along
with [""] or ["null"] in policyItem --> users, groups and roles.
Similar validation should be applied for data masking and row filter Policy.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
d73d91b36
Diff: https://reviews.apache.org/r/75004/diff/3/
Changes: https://reviews.apache.org/r/75004/diff/2-3/
Testing (updated)
-------
Verified while creating/updating Policy API fails, when users, groups, roles,
data masking, and row filter fields are all empty values or contain arrays with
empty strings (e.g. [""]) within the policy items.
Thanks,
Rakesh Gupta