----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75077/#review226656 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 11, 2024, 5:35 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75077/ > ----------------------------------------------------------- > > (Updated July 11, 2024, 5:35 a.m.) > > > Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika > Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4841 > https://issues.apache.org/jira/browse/RANGER-4841 > > > Repository: ranger > > > Description > ------- > > RANGER-4841 : Optimising POST xusers/ugsync/groupusers api, by removing the > update user-group membership logic. Moving the logic of getting the > addedBy/updatedBy userId to the parent thread. > Removing hardcoded userId of 1 which is used to set the addedBy/updatedBy > userId of user, group and user-group membership and replacing it by the > logged in user id. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/service/XGroupService.java > 98ee62612 > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > a4d6640a5 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > 5053cd6a5 > > > Diff: https://reviews.apache.org/r/75077/diff/2/ > > > Testing > ------- > > Validated the performace of POST xusers/ugsync/groupusers api with over 3 > million records in x_group_users table. > Below is the duration the api took to create 1000 user-group memberships > Before fix - 18 seconds > After fix - 15.5 seconds > > > Thanks, > > Anand Nadar > >
