fateh288 commented on code in PR #369: URL: https://github.com/apache/ranger/pull/369#discussion_r1697335608
########## agents-common/src/main/java/org/apache/ranger/plugin/service/RangerPluginAnalytics.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.ranger.plugin.service; + +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.ScheduledFuture; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import java.util.concurrent.atomic.DoubleAccumulator; + +import static java.util.concurrent.TimeUnit.SECONDS; + +public class RangerPluginAnalytics { + private static final Logger LOG = LoggerFactory.getLogger(RangerPluginAnalytics.class); + private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1); + private static final int SLEEP_DURATION = 300; + private ScheduledFuture<?> statusHandler; + + private final DoubleAccumulator countIsAccessAllowed = new DoubleAccumulator(Double::sum, 0L); + final Runnable asyncLoggerPluginAnalytics = () -> { + LOG.info("===========Ranger Plugin Analytics============="); + LOG.info("Accumulation period in seconds:"+SLEEP_DURATION); + LOG.info("Number of times isAccessAllowed was called:"+countIsAccessAllowed.getThenReset()); + }; + + public void startPluginAnalytics() { + stopPluginAnalytics(); + LOG.info("Starting Scheduled Plugin Analytics"); + statusHandler = scheduler.scheduleWithFixedDelay(asyncLoggerPluginAnalytics, 0, SLEEP_DURATION, SECONDS); + } + + public void stopPluginAnalytics() { + if (statusHandler == null){ + LOG.info("statusHandler is null, stop not required for asyncLoggerPluginAnalytics"); + return; + } + LOG.info("Attempting to cancel asyncLoggerPluginAnalytics"); + try { + scheduler.shutdown(); + statusHandler.cancel(true); + } + catch (Exception e){ Review Comment: Fixed. No exception thrown by these functions according to the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
