marco-luzzara opened a new pull request, #396:
URL: https://github.com/apache/ranger/pull/396
## What changes were proposed in this pull request?
This PR fixes some syntactic mistakes on the Dockerfiles involved in the
Ranger build in a Dockerized environment. The 3 main issues I have fixed are:
- `RUN if [ "${OS_NAME}" == "UBUNTU" ]; then ...`: the commands enclosed in
this if-condition will never be executed because the shell used for this
command is `/bin/sh`, which requires a single `=` for string comparison.
- For some reasons, the `ENV JAVA_HOME /usr/lib/...` Dockerfile command is
placed inside the `RUN` command. I put it before the `RUN` command in order to
use the `JAVA_HOME` env variable in the shell script.
- Many env variables are initialized using the alternative syntax `ENV
MY_ENV_VAR value1`, which is not compliant with the guidelines, that suggests
using `ENV MY_ENV_VAR=value1`. I quote from the [`ENV`
reference](https://docs.docker.com/reference/dockerfile/#env):
> The alternative syntax is supported for backward compatibility, but
discouraged for the reasons outlined above, and may be removed in a future
release.
I rewrote only some of them, in case you preferred another PR for a
general Dockerfile/compose improvements.
## How was this patch tested?
By running `./build_ranger_using_docker.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
