> On Oct. 3, 2024, 9:41 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > > Line 45 (original), 54 (patched) > > <https://reviews.apache.org/r/75222/diff/3/?file=2293510#file2293510line60> > > > > There are many APIs (most of the get APIs, such as > > getDatasetResources(), getDataShareResources(), etc) are only used by test > > code. Consider using some annotation (if any) to clearly mark them as > > test-only APIs.
These APIs will be useful in upcoming REST APIs for UI to list resources for a given project/dataset/datashare. So, I suggest to retain these APIs. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75222/#review226961 ----------------------------------------------------------- On Oct. 4, 2024, 6:50 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75222/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2024, 6:50 a.m.) > > > Review request for ranger, Anand Nadar, Asit Vadhavkar, Kishor Gollapalliwar, > Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Subhrat Chaudhary, and > Velmurugan Periasamy. > > > Bugs: RANGER-4948 > https://issues.apache.org/jira/browse/RANGER-4948 > > > Repository: ranger > > > Description > ------- > > - moved resouce-tries from GdsDataShareEvaluator to GdsPolicyEngine > - replaced iterations with streams style statements > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDataShareEvaluator.java > df4d06018 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDatasetEvaluator.java > 56397fe74 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDipEvaluator.java > ec81b4c3e > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDshidEvaluator.java > c56c55f77 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > a1593daaf > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsProjectEvaluator.java > c9fe1b63c > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsSharedResourceEvaluator.java > 309181344 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/gds/TestGdsPolicyEngine.java > c3884f261 > > agents-common/src/test/resources/policyengine/gds/test_gds_policy_engine_hive.json > 37b65b880 > > > Diff: https://reviews.apache.org/r/75222/diff/5/ > > > Testing > ------- > > - verified that all unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
