----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75230/ -----------------------------------------------------------
(Updated Oct. 24, 2024, 1:54 p.m.) Review request for ranger, Madhan Neethiraj and Ramesh Mani. Changes ------- Updated patch as per the review comments Bugs: RANGER-4933 https://issues.apache.org/jira/browse/RANGER-4933 Repository: ranger Description ------- Ranger API to Summary View of DataShares in a GDS Summary should have the following details. DataShare Number of Assets on the DataShare. Created by and when details. End of Support Date Tags (Labels) Keywords Number of external user which this DataShare is shared. Mapping of Requested Data to Response Properties: ------------------------------------------------ DataShare: "dataShares" Number of Assets on the DataShare: "totalResourceCount" Created by and when details: "createdBy" and "createTime" End of Support Date: "validitySchedule" Tags: "labels" Keywords: "keywords" Number of external user which this DataShare is shared: "principalsCount" Attached the document with Datashare summary API request and response details. Diffs (updated) ----- agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java d582e420f agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 0da5f2aaf security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 6c48c49f4 security-admin/db/mysql/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql PRE-CREATION security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql ed6d20b3d security-admin/db/oracle/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql PRE-CREATION security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 34a092e89 security-admin/db/postgres/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql PRE-CREATION security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 72a9afb83 security-admin/db/sqlanywhere/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql PRE-CREATION security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 70a2e00cd security-admin/db/sqlserver/patches/075-add-validity_schedule-labels-keywords-in-x_gds_dataset.sql PRE-CREATION security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 9bb946996 security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 42eb7dfaa security-admin/src/main/java/org/apache/ranger/entity/XXGdsDataset.java 6fdc5be95 security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 525a5eca3 security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java 659c07f16 Diff: https://reviews.apache.org/r/75230/diff/3/ Changes: https://reviews.apache.org/r/75230/diff/2-3/ Testing ------- Tested manually. File Attachments ---------------- DataShare summary view API details https://reviews.apache.org/media/uploaded/files/2024/10/10/cafc429e-2559-4c93-9506-10128682cfa5__SummaryView_Datashares_in_GDS_API_request_response.json DataShare summary view API details https://reviews.apache.org/media/uploaded/files/2024/10/10/b94bad0f-c98a-4a86-a3f6-4fd558c0b24c__SummaryView_Datashares_in_GDS_API_request_response.json Thanks, Radhika Kundam