> On Nov. 13, 2024, 7:49 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > > Lines 278 (patched) > > <https://reviews.apache.org/r/75265/diff/2/?file=2294166#file2294166line300> > > > > If there are more then one resource returned in line 272, is it > > possible that one of the resources will have a data-mask? In such case, is > > breaking out of the loop at line 272 appropriate?
If the user has access to unmasked column via any one resource, any mask specified in other resources are ignored. This seems reasonable, right? - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75265/#review227052 ----------------------------------------------------------- On Nov. 11, 2024, 8:43 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75265/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2024, 8:43 a.m.) > > > Review request for ranger, Abhishek Agarwal, Anand Nadar, Asit Vadhavkar, > Fateh Singh, Abhay Kulkarni, Mugdha Varadkar, Pradeep Agrawal, Radhika > Kundam, Ramesh Mani, and Subhrat Chaudhary. > > > Bugs: RANGER-4991 > https://issues.apache.org/jira/browse/RANGER-4991 > > > Repository: ranger > > > Description > ------- > > Updated GDS policy engine to support data mask and row filter specified in > shared resources > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 75328b985 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > 7bf8c7ca4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 232ef90da > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsAccessResult.java > 74a78e68d > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsDatasetEvaluator.java > 7298825c2 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsPolicyEngine.java > ddac8da1a > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/gds/GdsSharedResourceEvaluator.java > d03dd00c9 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/gds/TestGdsPolicyEngine.java > 7bfebbb99 > agents-common/src/test/resources/plugin/hive_gds_info.json fd2d9ff7e > agents-common/src/test/resources/policyengine/gds/gds_info_hive_access.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/gds/gds_info_hive_data_mask.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/gds/test_gds_policy_engine_hive.json > 969c184f7 > > agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_data_mask.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_row_filter.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/75265/diff/2/ > > > Testing > ------- > > - added unit tests to validate data mask and row filter use cases > > > Thanks, > > Madhan Neethiraj > >
