----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75271/#review227077 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 376 (patched) <https://reviews.apache.org/r/75271/#comment315360> includeUnusedPolicyAttributes => includePolicyMetaAttributes security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 2683 (patched) <https://reviews.apache.org/r/75271/#comment315362> fillPolicyMetaAttributes() => getPoliciesWithMetaAttributes() security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java Lines 343 (patched) <https://reviews.apache.org/r/75271/#comment315361> - Query text should be registered in jpa_named_queries.xml, with something like: <named-query name="XXPolicy.getMetaAttributesForPolicies"> <query>SELECT obj.id, obj.createdBy, obj.createTime, obj.updatedBy, obj.updateTime FROM XXPolicy obj WHERE obj.id IN :policyIds</query> </named-query> - move RangerBaseModelService.getResourcesByIds(List<Long> ids) => XXPolicyDao.getMetaAttributesForPolicies(List<Long> policyIds) - Madhan Neethiraj On Nov. 19, 2024, 7:01 a.m., Guru Thejus Arveti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75271/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2024, 7:01 a.m.) > > > Review request for ranger, Madhan Neethiraj and Pradeep Agrawal. > > > Bugs: RANGER-4996 > https://issues.apache.org/jira/browse/RANGER-4996 > > > Repository: ranger > > > Description > ------- > > RANGER-4996: Made meta attributes fields in policy rest api response > configurable for retrieval > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 97072391e > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 0dee87734 > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > c8d1e5d08 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > b93b63f85 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > ce3a95766 > > security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java > 26f76578e > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 1af339010 > > > Diff: https://reviews.apache.org/r/75271/diff/2/ > > > Testing > ------- > > Tested the /service/public/v2/api/policy rest api from swagger and as well as > from postman and verified that createTime, updateTime, createdBy, updatedBy > fields are being retrieved in the response when the > ranger.admin.api.include.policy.meta.attributes flag is set > > > Thanks, > > Guru Thejus Arveti > >
