mneethiraj commented on code in PR #414: URL: https://github.com/apache/ranger/pull/414#discussion_r1857396527
########## agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java: ########## @@ -308,7 +309,7 @@ public void setPolicies(ServicePolicies policies) { if (LOG.isDebugEnabled()) { LOG.debug("==> setPolicies(" + policies + ")"); } - + this.serviceConfigs = policies != null ? (policies.getServiceConfig() != null ? policies.getServiceConfig() : new HashMap<>()) : new HashMap<>(); Review Comment: `this.serviceConfigs = (policies != null && policies.getServiceConfig() != null) ? policies.getServiceConfig() : new HashMap<>();` ########## agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java: ########## @@ -76,6 +76,7 @@ public class RangerBasePlugin { private final List<RangerChainedPlugin> chainedPlugins; private final boolean dedupStrings; private boolean isUserStoreEnricherAddedImplcitly = false; + private Map<String, String> serviceConfigs; Review Comment: White space/tab alignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org