mneethiraj commented on code in PR #413: URL: https://github.com/apache/ranger/pull/413#discussion_r1858573408
########## plugin-schema-registry/pom.xml: ########## @@ -15,27 +15,25 @@ See the License for the specific language governing permissions and limitations under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> <modelVersion>4.0.0</modelVersion> - <artifactId>ranger-schema-registry-plugin</artifactId> - <name>SchemaRegistry Security Plugin</name> - <description>SchemaRegistry Security Plugin</description> - <packaging>jar</packaging> <parent> <groupId>org.apache.ranger</groupId> <artifactId>ranger</artifactId> <version>3.0.0-SNAPSHOT</version> <relativePath>..</relativePath> </parent> + <artifactId>ranger-schema-registry-plugin</artifactId> + <packaging>jar</packaging> + <name>SchemaRegistry Security Plugin</name> + <description>SchemaRegistry Security Plugin</description> <properties> <avro.version>1.11.3</avro.version> Review Comment: When a dependency is used only within a plugin module, I suggest keeping its version property in plugin module's pom.xml. For rest of Ranger libraries, version properties should be consolidated in root pom.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
