mneethiraj commented on code in PR #444:
URL: https://github.com/apache/ranger/pull/444#discussion_r1880450875
##########
credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java:
##########
@@ -17,80 +17,82 @@
* under the License.
*/
- package org.apache.ranger.credentialapi;
-import java.util.ArrayList;
-import java.util.List;
+package org.apache.ranger.credentialapi;
import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.security.alias.CredentialProvider;
import org.apache.hadoop.security.alias.CredentialProviderFactory;
import org.apache.hadoop.security.alias.JavaKeyStoreProvider;
-public class CredentialReader {
+import java.util.ArrayList;
+import java.util.List;
- public static String getDecryptedString(String
CrendentialProviderPath,String alias, String storeType) {
- String credential=null;
- try{
- if(CrendentialProviderPath==null || alias==null){
- return null;
- }
- char[] pass = null;
- Configuration conf = new Configuration();
- String
crendentialProviderPrefixJceks=JavaKeyStoreProvider.SCHEME_NAME + "://file";
- String
crendentialProviderPrefixLocalJceks="localjceks://file";
-
crendentialProviderPrefixJceks=crendentialProviderPrefixJceks.toLowerCase();
+public class CredentialReader {
+ private CredentialReader() {
+ }
- String crendentialProviderPrefixBcfks = "bcfks" + "://file";
- String crendentialProviderPrefixLocalBcfks= "localbcfks" +
"://file";
-
crendentialProviderPrefixBcfks=crendentialProviderPrefixBcfks.toLowerCase();
-
crendentialProviderPrefixLocalBcfks=crendentialProviderPrefixLocalBcfks.toLowerCase();
+ public static String getDecryptedString(String credentialProviderPath,
String alias, String storeType) {
+ String credential = null;
+ try {
+ if (credentialProviderPath == null || alias == null) {
+ return null;
+ }
+ char[] pass = null;
+ Configuration conf = new Configuration();
+ String crendentialProviderPrefixJceks =
JavaKeyStoreProvider.SCHEME_NAME + "://file";
+ String crendentialProviderPrefixLocalJceks = "localjceks://file";
+ crendentialProviderPrefixJceks =
crendentialProviderPrefixJceks.toLowerCase();
- CrendentialProviderPath=CrendentialProviderPath.trim();
- alias=alias.trim();
-
if(CrendentialProviderPath.toLowerCase().startsWith(crendentialProviderPrefixJceks)
||
-
CrendentialProviderPath.toLowerCase().startsWith(crendentialProviderPrefixLocalJceks)
||
-
CrendentialProviderPath.toLowerCase().startsWith(crendentialProviderPrefixBcfks)
||
-
CrendentialProviderPath.toLowerCase().startsWith(crendentialProviderPrefixLocalBcfks)){
-
conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
- //UserProvider.SCHEME_NAME + ":///,"
+
- CrendentialProviderPath);
- }else{
- if(CrendentialProviderPath.startsWith("/")){
- if(StringUtils.equalsIgnoreCase(storeType,
"bcfks")) {
-
conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
CrendentialProviderPath);
- } else {
-
conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
-
//UserProvider.SCHEME_NAME + ":///," +
-
JavaKeyStoreProvider.SCHEME_NAME + "://file" + CrendentialProviderPath);
- }
+ String crendentialProviderPrefixBcfks = "bcfks" + "://file";
+ String crendentialProviderPrefixLocalBcfks = "localbcfks" +
"://file";
+ crendentialProviderPrefixBcfks =
crendentialProviderPrefixBcfks.toLowerCase();
Review Comment:
AFAIK, there is no checkstyle rule available for this. if/when it becomes
available, we should include it in our checkstyle.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
