----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74613/#review227217 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Line 82 (original), 86 (patched) <https://reviews.apache.org/r/74613/#comment315454> Instead of 'isSolrPlugin' parameter, I suggest using MiscUtil.getApplicationType() to determine if Solr plugin is the context. With this approach, the changes can be isolated to only SolrAuditDestination and SolrAppUtil classes i.e. changes in following classes can be avoided: - AuditProviderFactory - RangerBasePlugin - Madhan Neethiraj On Feb. 4, 2025, 10:18 a.m., sanket shelar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74613/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2025, 10:18 a.m.) > > > Review request for ranger, dinesh akhand, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh > Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3346 > https://issues.apache.org/jira/browse/RANGER-3346 > > > Repository: ranger > > > Description > ------- > > SolrAuditDestination class connects to Solr by building client with > HttpClientUtil (from SolrJ library). > It's fine except in case of Solr Ranger Plugin. The Solr server uses the > SolrJ lib as well for communication among its nodes and sets static/global > configuration inside the HttpClientUtil which makes the SolrAuditDestination > class's client to misbehave as sending the audits request with a header which > forces the authentication to PKI. Prior to Solr 8.8 it leaded to only warning > level Exceptions but after this version this will cause failure when sending > audits. > > Relevant Solr JIRA about changing the implementation of HttpClientUtil class: > https://issues.apache.org/jira/browse/SOLR-15388 > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > 4be6002e3 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > 619c94c37 > agents-audit/src/main/java/org/apache/ranger/audit/utils/SolrAppUtil.java > 83612bde7 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 495ce3b83 > > > Diff: https://reviews.apache.org/r/74613/diff/2/ > > > Testing > ------- > > tested for solr plugins > > > Thanks, > > sanket shelar > >
