----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75359/#review227236 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 473 (patched) <https://reviews.apache.org/r/75359/#comment315475> This is not needed i think security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 1576 (patched) <https://reviews.apache.org/r/75359/#comment315474> Add opening and closing debug messages security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 696 (patched) <https://reviews.apache.org/r/75359/#comment315476> remove if condition. use logger.debug directly security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 707 (patched) <https://reviews.apache.org/r/75359/#comment315477> remove if statement security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 1766 (patched) <https://reviews.apache.org/r/75359/#comment315478> make it in API format security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 3214 (patched) <https://reviews.apache.org/r/75359/#comment315480> keep single line statement, avoid single statement in multilines security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4427 (patched) <https://reviews.apache.org/r/75359/#comment315479> remove if debug messages from everywhere - Pradeep Agrawal On Feb. 8, 2025, 9:06 a.m., Guru Thejus Arveti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75359/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2025, 9:06 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > API to delete multiple policies using a wildcard > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 7beef34c7 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > e8ea726cb > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 7b1eb7fe7 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f7c521111 > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 193face94 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 56eefba40 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 7747e327a > > > Diff: https://reviews.apache.org/r/75359/diff/1/ > > > Testing > ------- > > Locally tested using docker by bulk creating ~10k policies and deleting them > by using the API. Time to execution ~25-30sec > > > Thanks, > > Guru Thejus Arveti > >
