-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75347/
-----------------------------------------------------------
(Updated Feb. 10, 2025, 11:57 a.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Bugs: RANGER-5111
https://issues.apache.org/jira/browse/RANGER-5111
Repository: ranger
Description
-------
The Summary API should support distinct filtering capabilities that include all
unique labels and keywords associated with the datashares returned in the
response. Additionally, the API should provide the count of datashares linked
to each specific label and keyword. This enhancement ensures that the data can
be effectively utilized for advanced filtering on the UI.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java
260ebc0a8
agents-common/src/main/java/org/apache/ranger/plugin/store/PList.java
4bf2ee02f
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 7916f0818
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 0d3ef3d76
Diff: https://reviews.apache.org/r/75347/diff/10/
Changes: https://reviews.apache.org/r/75347/diff/9-10/
Testing
-------
Tested locally.
Summary view with additionalInfo(Labels & Keywords) of DataShares in GDS:
------------------------------------------------------------------------
Request:
-------
curl -X GET -u <username>:<pwd> '<ranger
url>/service/gds/dataset/enhancedsummary?pageSize=1
Response:
--------
Response consists of datasetSummary along with additionalInfo
additionalInfo: map with relevant labels and keywords with dataset counts
{
"startIndex": 0,
"pageSize": 1,
"totalCount": 10,
"resultSize": 1,
"sortType": "asc",
"sortBy": "datasetId",
"queryTimeMS": 1738828193935,
"list": [
{
"id": 9,
"guid": "883f33a0-0919-4150-a749-38dead04411d",
"isEnabled": true,
"createdBy": "Admin",
"updatedBy": "Admin",
"createTime": 1738200913000,
"updateTime": 1738200913000,
"version": 1,
"name": "ds-1",
"description": "test dataset validity",
"permissionForCaller": "ADMIN",
"principalsCount": {
"ROLE": 0,
"USER": 0,
"GROUP": 0
},
"aclPrincipalsCount": {
"ROLE": 0,
"USER": 1,
"GROUP": 0
},
"projectsCount": 0,
"totalResourceCount": 0,
"validitySchedule": {
"startTime": "2025/01/29 00:00:00",
"endTime": "2025/02/15 00:00:00",
"timeZone": "Pacific/Pitcairn"
},
"labels": [
"testLabel1"
],
"keywords": [
"testKW1"
]
}
],
"additionalInfo": {
"keywordCounts": {
"testKW4": 2,
"testKW5": 2,
"testKW2": 1,
"testKW3": 1,
"testKW1": 3
},
"labelCounts": {
"testLabel4": 2,
"testLabel5": 2,
"testLabel2": 1,
"testLabel3": 1,
"testLabel1": 3
}
},
"listSize": 1
}
Thanks,
Radhika Kundam
