rameeshm commented on code in PR #528: URL: https://github.com/apache/ranger/pull/528#discussion_r1950272955
########## security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java: ########## @@ -1911,18 +1912,23 @@ List<RangerGrant> transformPolicyItemsToGrants(List<RangerPolicyItem> policyItem List<RangerPolicyItemCondition> policyItemConditions = policyItem.getConditions(); List<String> policyItemAccessTypes = policyItemAccesses.stream().map(RangerPolicyItemAccess::getType).collect(Collectors.toList()); - List<String> policyItemConditionValues = policyItemConditions.stream().flatMap(x -> x.getValues().stream()).collect(Collectors.toList()); + + List<RangerPolicy.RangerPolicyItemCondition> policyItemConditionExpressions = policyItemConditions.stream().filter(c -> c.getType().equals(GDS_POLICY_EXPR_CONDITION)).collect(Collectors.toList()); + List<String> expressions = policyItemConditionExpressions.stream().flatMap(x -> x.getValues().stream()).collect(Collectors.toList()); + + List<RangerPolicy.RangerPolicyItemCondition> policyItemConditionValiditySchedules = policyItemConditions.stream().filter(c -> c.getType().equals(GDS_POLICY_VALIDITY_SCHEDULE_CONDITION)).collect(Collectors.toList()); Review Comment: @mneethiraj This review comment has been addressed and new update the pull request done. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org