-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75359/#review227282
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 1582 (patched)
<https://reviews.apache.org/r/75359/#comment315530>

    nit: like other methods could use "ret" for returning values, please do the 
same for other method as well



security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 4495 (patched)
<https://reviews.apache.org/r/75359/#comment315531>

    put the exit debug also?
    LOG.debug("<== ServiceREST.ensureAdminAndAuditAccessForRetrievedPolicies(" 
+ serviceName + ")");



security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java
Lines 1521 (patched)
<https://reviews.apache.org/r/75359/#comment315532>

    @org.junit.jupiter.api.Test is this different from @Test?


- Ramesh Mani


On March 6, 2025, 8:07 a.m., Guru Thejus Arveti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75359/
> -----------------------------------------------------------
> 
> (Updated March 6, 2025, 8:07 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Pradeep Agrawal, and Ramesh Mani.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> API to delete multiple policies using a wildcard
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java
>  b4d549df7 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 
> 5a5556a2f 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 7beef34c7 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> 6833048e6 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> 7b1eb7fe7 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> f7c521111 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 
> 7747e327a 
> 
> 
> Diff: https://reviews.apache.org/r/75359/diff/5/
> 
> 
> Testing
> -------
> 
> Locally tested using docker by bulk creating ~10k policies and deleting them 
> by using the API. Time to execution ~25-30sec
> 
> 
> Thanks,
> 
> Guru Thejus Arveti
> 
>

Reply via email to