kumaab commented on code in PR #545:
URL: https://github.com/apache/ranger/pull/545#discussion_r2004729660


##########
security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java:
##########
@@ -206,8 +205,18 @@ private void runRunnables(final List<Runnable> runnables, 
final boolean isParent
                             LOG.debug("Failed to commit TransactionService 
transaction, throwable:[{}]", String.valueOf(e));
                         }
                     }
-                }
-                while (isParentTransactionCommitted && 
!isThisTransactionCommitted);
+
+                    isThisTransactionCommitted = result == runnable;
+
+                    if (isParentTransactionCommitted) {
+                        if (!isThisTransactionCommitted) {
+                            LOG.info("Failed to commit runnable:[{}]. Will 
retry!", runnable);
+                            count ++;
+                        } else {
+                            LOG.debug("Committed runnable:[{}].", runnable);
+                        }
+                    }
+                } while (isParentTransactionCommitted && 
!isThisTransactionCommitted && count < 5);

Review Comment:
   I'll remove the test code and update, it was not intended for review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to