mneethiraj commented on code in PR #542:
URL: https://github.com/apache/ranger/pull/542#discussion_r2019624112
##########
dev-support/ranger-docker/README.md:
##########
@@ -81,9 +81,9 @@ docker-compose -f docker-compose.ranger-base-ubi.yml build
--no-cache
# To enable file based sync source for usersync do:
# export ENABLE_FILE_SYNC_SOURCE=true
-# valid values for RANGER_DB_TYPE: mysql/postgres/oracle
+# valid values for RANGER_DB_TYPE: mysql/postgres/oracle/sqlserver
Review Comment:
`sqlserver` is not supported. Please revert changes in this line.
##########
dev-support/ranger-docker/README.md:
##########
@@ -81,9 +81,9 @@ docker-compose -f docker-compose.ranger-base-ubi.yml build
--no-cache
# To enable file based sync source for usersync do:
# export ENABLE_FILE_SYNC_SOURCE=true
-# valid values for RANGER_DB_TYPE: mysql/postgres/oracle
+# valid values for RANGER_DB_TYPE: mysql/postgres/oracle/sqlserver
-docker-compose -f docker-compose.ranger.yml -f
docker-compose.ranger-${RANGER_DB_TYPE}.yml -f
docker-compose.ranger-usersync.yml -f docker-compose.ranger-tagsync.yml up -d
+docker-compose -f docker-compose.ranger.yml -f
docker-compose.ranger-usersync.yml -f docker-compose.ranger-tagsync.yml up -d
Review Comment:
Other references to `docker codocker-compose.ranger-${RANGER_DB_TYPE}.yml`
in README.md should be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
