adoroszlai commented on code in PR #1: URL: https://github.com/apache/ranger-tools/pull/1#discussion_r2179402861
########## .github/workflows/push.yaml: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: push + +# This workflow builds (if necessary) and tags the Docker image, +# possibly for multiple Java versions. + +on: + push: + paths: + - 'docker/**' + - '.github/workflows/push.yaml' Review Comment: ```suggestion - '.github/workflows/build.yaml' - '.github/workflows/build-and-tag.yaml' - '.github/workflows/push.yaml' ``` ########## docker/README.md: ########## @@ -0,0 +1,24 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +# Apache Ranger Tools + +[ranger-tools/docker](https://github.com/apache/ranger-tools/docker) contains utilities for ranger docker base image development, base images are the underlying images used to run and test Apache Ranger in Docker containers. Review Comment: This link is not valid. ```suggestion This directory contains utilities for ranger docker base image development, base images are the underlying images used to run and test Apache Ranger in Docker containers. ``` ########## .github/workflows/pr.yaml: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: PR + +# This workflow builds the image for pull requests. + +on: + pull_request: + types: [opened, ready_for_review, synchronize] + paths: + - 'docker/**' + - '.github/workflows/pr.yaml' Review Comment: Also need to trigger if `build.yaml` is changed. ```suggestion - '.github/workflows/build.yaml' - '.github/workflows/pr.yaml' ``` ########## docker/README.md: ########## @@ -0,0 +1,24 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +# Apache Ranger Tools Review Comment: ```suggestion # Apache Ranger Base Image ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
