fateh288 commented on code in PR #569: URL: https://github.com/apache/ranger/pull/569#discussion_r2193973234
########## liquibase-database-upgrade/changelogs/kms/db/test_3.x/sleep.xml: ########## @@ -0,0 +1,37 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<databaseChangeLog + xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext"; + xmlns:pro="http://www.liquibase.org/xml/ns/pro"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog + http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd + http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd + http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd";> + + <changeSet id="6_sleep" author="fateh"> + <sql dbms="postgresql" > + select pg_sleep(60); + </sql> + <sql dbms="mysql" > Review Comment: All the changesets/changelogs I have added in this PR are for demonstration purposes only to showcase what is possible in liquibase and the features it provides. This particular changeset I am trying to demonstrate that a single changeset with a unique id and author can be used for multiple databases if we specify the dbms attribute. Here sleep.xml has a changeset with changeSet id="6_sleep" author="fateh" which is used to specify behavior across multiple databases i.e. postgres as well as mysql. This can drastically help reduce the number of changesets one has to keep track of since single changeset can now be used for multiple dbs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
