mneethiraj commented on code in PR #601:
URL: https://github.com/apache/ranger/pull/601#discussion_r2195860915
##########
dev-support/ranger-docker/scripts/ranger-hadoop.sh:
##########
@@ -36,6 +33,9 @@ then
su -c "cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys" yarn
su -c "chmod 0600 ~/.ssh/authorized_keys" yarn
+ ssh-keygen -A
Review Comment:
It seems lines 36 & 37 should be in else clause of the if block at line 27.
Please review.
##########
dev-support/ranger-docker/scripts/ranger-hbase.sh:
##########
@@ -31,6 +27,9 @@ then
su -c "cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys" hbase
su -c "chmod 0600 ~/.ssh/authorized_keys" hbase
+ ssh-keygen -A
Review Comment:
It seems lines 30 & 31 should be in `else` clause of the `if` block at line
21. Please review.
##########
dev-support/ranger-docker/docker-compose.ranger.yml:
##########
@@ -4,9 +4,10 @@ services:
context: .
dockerfile: Dockerfile.ranger
args:
+ - RANGER_BASE_IMAGE=${RANGER_BASE_IMAGE}
+ - RANGER_BASE_VERSION=${RANGER_BASE_VERSION}
- RANGER_VERSION=${RANGER_VERSION}
- RANGER_DB_TYPE=${RANGER_DB_TYPE}
- - RANGER_ADMIN_JAVA_VERSION=${RANGER_ADMIN_JAVA_VERSION}
Review Comment:
I suggest to retain the flexibility to use different Java versions for
build, Ranger admin and plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
