Re: [PR] RANGER-5215 : Policy authorisation fails for Ranger Plugins in case of users/groups converted by Ranger userysnc as per given Regex [ranger]

[via GitHub]

dhavalshah9131 commented on code in PR #584:
URL: https://github.com/apache/ranger/pull/584#discussion_r2230996994


##########
ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/transform/RegEx.java:
##########
@@ -17,34 +17,27 @@
  * under the License.
  */
 
-package org.apache.ranger.usergroupsync;
-
-import org.apache.ranger.unixusersync.config.UserGroupSyncConfig;
+package org.apache.ranger.ugsyncutil.transform;
 
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 public class RegEx extends AbstractMapper {
-    private final UserGroupSyncConfig           config = 
UserGroupSyncConfig.getInstance();
-    private       LinkedHashMap<String, String> replacementPattern;
+    private LinkedHashMap<String, String> replacementPattern;
 
     public LinkedHashMap<String, String> getReplacementPattern() {
         return replacementPattern;
     }
 
     @Override
-    public void init(String baseProperty) {
-        logger.info("Initializing for {}", baseProperty);
-
+    public void init(String baseProperty, List<String> regexPatterns, String 
regexSeparator) {
+        AbstractMapper.logger.info("Initializing for {}", baseProperty);

Review Comment:
   Not need of import AbstractMapper is inherited.



##########
ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/transform/RegEx.java:
##########
@@ -17,34 +17,27 @@
  * under the License.
  */
 
-package org.apache.ranger.usergroupsync;
-
-import org.apache.ranger.unixusersync.config.UserGroupSyncConfig;
+package org.apache.ranger.ugsyncutil.transform;
 
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 public class RegEx extends AbstractMapper {
-    private final UserGroupSyncConfig           config = 
UserGroupSyncConfig.getInstance();
-    private       LinkedHashMap<String, String> replacementPattern;
+    private LinkedHashMap<String, String> replacementPattern;
 
     public LinkedHashMap<String, String> getReplacementPattern() {
         return replacementPattern;
     }
 
     @Override
-    public void init(String baseProperty) {
-        logger.info("Initializing for {}", baseProperty);
-
+    public void init(String baseProperty, List<String> regexPatterns, String 
regexSeparator) {
+        AbstractMapper.logger.info("Initializing for {}", baseProperty);

Review Comment:
   No need of import AbstractMapper is inherited.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org