mneethiraj commented on code in PR #646:
URL: https://github.com/apache/ranger/pull/646#discussion_r2306358901
##########
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java:
##########
@@ -1072,13 +1072,36 @@ private void updateFromGdsResult(RangerAccessResult
result) {
if (gdsResult != null) {
if (result.getPolicyType() == RangerPolicy.POLICY_TYPE_ACCESS) {
+ // pick access result from GDS policies only if there is no
decision yet
if (!result.getIsAccessDetermined() &&
gdsResult.getIsAllowed()) {
result.setIsAllowed(true);
result.setIsAccessDetermined(true);
result.setPolicyId(gdsResult.getPolicyId());
result.setPolicyVersion(gdsResult.getPolicyVersion());
result.setPolicyPriority(RangerPolicy.POLICY_PRIORITY_NORMAL);
}
+ } else if (result.getPolicyType() ==
RangerPolicy.POLICY_TYPE_ROWFILTER) {
Review Comment:
Good point. Thanks for the suggestion @vyommani.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]