bhaveshamre commented on code in PR #647:
URL: https://github.com/apache/ranger/pull/647#discussion_r2329623709
##########
security-admin/src/test/java/org/apache/ranger/service/TestXGroupService.java:
##########
@@ -18,81 +18,73 @@
*/
package org.apache.ranger.service;
-import org.apache.ranger.biz.RangerBizUtil;
-import org.apache.ranger.common.StringUtil;
+import org.apache.ranger.common.RESTErrorUtil;
import org.apache.ranger.common.db.BaseDao;
import org.apache.ranger.db.RangerDaoManager;
import org.apache.ranger.db.XXGroupDao;
import org.apache.ranger.db.XXPortalUserDao;
import org.apache.ranger.entity.XXDBBase;
import org.apache.ranger.entity.XXGroup;
import org.apache.ranger.entity.XXPortalUser;
-import org.apache.ranger.util.RangerEnumUtil;
import org.apache.ranger.view.VXGroup;
-import org.junit.FixMethodOrder;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.MethodSorters;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Mockito;
-import org.mockito.junit.MockitoJUnitRunner;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.mockito.junit.jupiter.MockitoSettings;
+import org.mockito.quality.Strictness;
+import java.lang.reflect.Field;
import java.util.Date;
-import static
org.apache.ranger.service.RangerBaseModelService.OPERATION_CREATE_CONTEXT;
import static
org.apache.ranger.service.RangerBaseModelService.OPERATION_UPDATE_CONTEXT;
+import static org.mockito.Mockito.lenient;
-@RunWith(MockitoJUnitRunner.Silent.class)
-@FixMethodOrder(MethodSorters.NAME_ASCENDING)
+/**
+ * @generated by Cursor
+ * @description : Unit Test cases for XGroupService
+ */
+
+@ExtendWith(MockitoExtension.class)
+@TestMethodOrder(MethodOrderer.MethodName.class)
+@MockitoSettings(strictness = Strictness.LENIENT)
public class TestXGroupService {
+ @Spy
@InjectMocks
XGroupService xGroupService;
@Mock
RangerDaoManager daoManager;
@Mock
- XXGroupDao xXGroupDao;
-
- @Mock
- XXGroup resource;
+ BaseDao<XXGroup> entityDao;
@Mock
- VXGroup vxGroup;
+ XXGroupDao xXGroupDao;
@Mock
XXPortalUserDao xXPortalUserDao;
- @Mock
- BaseDao entityDao;
-
- @Mock
- XXDBBase xXDBBase;
-
@Mock
XXPortalUser tUser;
@Mock
- RangerEnumUtil xaEnumUtil;
-
- @Mock
- StringUtil stringUtil;
-
- @Mock
- RangerBizUtil bizUtil;
+ XXDBBase xXDBBase;
@Mock
- AbstractBaseResourceService abstractBaseResourceService;
+ RESTErrorUtil restErrorUtil;
- @Test
- public void test1GetGroupByGroupName() {
- Mockito.when(daoManager.getXXGroup()).thenReturn(xXGroupDao);
- XXGroup xxGroup = createXXGroup();
-
Mockito.when(xXGroupDao.findByGroupName(xxGroup.getName())).thenReturn(xxGroup);
- Mockito.when(daoManager.getXXPortalUser()).thenReturn(xXPortalUserDao);
-
Mockito.when(xXPortalUserDao.getById(xxGroup.getAddedByUserId())).thenReturn(tUser);
- xGroupService.getGroupByGroupName(xxGroup.getName());
+ @BeforeEach
+ public void setup() throws Exception {
+ setSuperField(xGroupService, "entityDao", entityDao,
org.apache.ranger.service.AbstractBaseResourceService.class);
Review Comment:
It's Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
