vikaskr22 commented on code in PR #680:
URL: https://github.com/apache/ranger/pull/680#discussion_r2386979441
##########
kms/config/kms-webapp/dbks-site.xml:
##########
@@ -405,6 +405,12 @@
<value>false</value>
<description></description>
</property>
+
+ <property>
+ <name>ranger.ks.hsm.masterkey.alias</name>
+ <value></value>
Review Comment:
@ChinmayHegde24 , can you please confirm following :
In dbks-site.xml, you are keeping this as empty. And in RangerHSM.java, how
will following behave:
this.alias = conf.get(MK_ALIAS, DEFAULT_ALIAS); ?
is it possible that it will initialise this.alias="" ? As per API , if this
key doesn't exist, then default will be used. But here key will exist with
empty value.
Pls check and confirm this case.
Other things look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
