pradeepagrawal8184 commented on code in PR #341:
URL: https://github.com/apache/ranger/pull/341#discussion_r2405138004
##########
security-admin/scripts/dba_script.py:
##########
@@ -1758,7 +1767,7 @@ def main(argv):
if AUDIT_DB_FLAVOR == "MYSQL":
MYSQL_CONNECTOR_JAR=CONNECTOR_JAR
- audit_sqlObj =
MysqlConf(audit_db_host,MYSQL_CONNECTOR_JAR,JAVA_BIN,db_ssl_enabled,db_ssl_required,db_ssl_verifyServerCertificate,javax_net_ssl_keyStore,javax_net_ssl_keyStorePassword,javax_net_ssl_trustStore,javax_net_ssl_trustStorePassword,db_ssl_auth_type)
+ audit_sqlObj =
MysqlConf(audit_db_host,MYSQL_CONNECTOR_JAR,JAVA_BIN,db_ssl_enabled,db_ssl_required,db_ssl_verifyServerCertificate,javax_net_ssl_keyStore,javax_net_ssl_keyStorePassword,javax_net_ssl_trustStore,javax_net_ssl_trustStorePassword,db_ssl_auth_type,db_allow_public_key_retrieval))
Review Comment:
Remove additional closing bracket added at the end of this line else install
will fail.
##########
kms/scripts/db_setup.py:
##########
@@ -711,11 +715,12 @@ def main(argv):
is_override_db_connection_string=globalDict['is_override_db_connection_string'].lower()
if 'db_override_jdbc_connection_string' in globalDict:
db_override_jdbc_connection_string=globalDict['db_override_jdbc_connection_string'].strip()
-
+ if 'db_allow_public_key_retrieval' in globalDict:
Review Comment:
Fix the indentation issue in this line and next line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
