Copilot commented on code in PR #713:
URL: https://github.com/apache/ranger/pull/713#discussion_r2457583031
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_access.json:
##########
@@ -13,135 +13,135 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "column: sales.prospects.channel, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "sales", "table":
"prospects", "column": "channel" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "table: sales.orders, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "database: sales, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "sales" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ],"allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
Review Comment:
Missing space after comma between 'datasetIds' array and 'allowedByDatasets'
field. Add a space after the comma for consistency with JSON formatting in the
rest of the file.
```suggestion
"result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_row_filter.json:
##########
@@ -252,55 +252,55 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"isAllowed": false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
},
{
"name": "table: sales.orders, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"isAllowed": false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
},
{
"name": "table: finance.invoices, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "isAllowed": false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "isAllowed": false, "isAudited": true,
"policyId": -1 }
},
{
"name": "table: finance.payments, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"payments" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "isAllowed": false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "isAllowed": false, "isAudited": true,
"policyId": -1 }
},
{
"name": "table: shipping.shipments, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "shipping", "table":
"shipments" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"isAllowed": false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"datasetIds": [ 2 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
},
{
"name": "table: customers.contact_info, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "customers", "table":
"contact_info" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "isAllowed": false, "isAudited": true, "policyId":
-1 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "isAllowed": false,
"isAudited": true, "policyId": -1 }
},
{
"name": "table: operations.facilities, user: scott, access: select",
"request": {
"resource": { "elements": { "database": "operations", "table":
"facilities" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-4" ], "projects": null, "isAllowed":
false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-4" ], "projects": null, "datasetIds":
[ 4 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
Review Comment:
Extra space after comma following 'datasetIds' array. Remove the extra space
to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-4" ], "projects": null,
"datasetIds": [ 4 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_row_filter.json:
##########
@@ -310,7 +310,7 @@
"resource": { "elements": { "database": "operations", "table":
"facilities" } },
"accessType": "select", "user": "scott", "userGroups": []
},
- "result": { "datasets": [ "dataset-4" ], "projects": null, "isAllowed":
false, "isAudited": true, "policyId": -1 }
+ "result": { "datasets": [ "dataset-4" ], "projects": null, "datasetIds":
[ 4 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
Review Comment:
Extra space after comma following 'datasetIds' array. Remove the extra space
to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-4" ], "projects": null,
"datasetIds": [ 4 ], "isAllowed": false, "isAudited": true, "policyId": -1 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_access.json:
##########
@@ -13,135 +13,135 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "column: sales.prospects.channel, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "sales", "table":
"prospects", "column": "channel" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "table: sales.orders, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "database: sales, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "sales" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ],"allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds1-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds1-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1" ],
"isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds2-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds2-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-2" ],
"isAllowed": true, "isAudited": true, "policyId": 2002 }
},
{
"name": "table: finance.payments, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"payments" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "database: finance, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "finance" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "table: shipping.shipments, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "shipping", "table":
"shipments" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-2" ], "isAllowed": true, "isAudited": true,
"policyId": 2002 }
+ "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"datasetIds": [ 2 ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
},
{
"name": "database: shipping, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "shipping" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-2" ], "isAllowed": true, "isAudited": true,
"policyId": 2002 }
+ "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"datasetIds": [ 2 ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
},
{
"name": "table: customers.contact_info, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "customers", "table":
"contact_info" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "allowedByDatasets": [ "dataset-3", "dataset-6" ],
"isAllowed": true, "isAudited": true, "policyId": 2003 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3", "dataset-6" ], "isAllowed": true, "isAudited": true, "policyId":
2003 }
},
{
"name": "table: customers.contact_info, user: ds3-user, access:
select",
"request": {
"resource": { "elements": { "database": "customers", "table":
"contact_info" } },
"accessType": "select", "user": "ds3-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "allowedByDatasets": [ "dataset-3" ], "isAllowed":
true, "isAudited": true, "policyId": 2003 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3" ], "isAllowed": true, "isAudited": true, "policyId": 2003 }
},
{
"name": "table: customers.contact_info, user: ds6-user, access:
select",
"request": {
"resource": { "elements": { "database": "customers", "table":
"contact_info" } },
"accessType": "select", "user": "ds6-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "allowedByDatasets": [ "dataset-6" ], "isAllowed":
true, "isAudited": true, "policyId": 2006 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-6" ], "isAllowed": true, "isAudited": true, "policyId": 2006 }
},
{
"name": "database: customers, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "customers" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "allowedByDatasets": [ "dataset-3", "dataset-6" ],
"isAllowed": true, "isAudited": true, "policyId": 2003 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3", "dataset-6" ], "isAllowed": true, "isAudited": true, "policyId":
2003 }
Review Comment:
Extra space after comma following 'projects' array. Remove the extra space
to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3", "dataset-6" ], "isAllowed": true, "isAudited": true, "policyId":
2003 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_data_mask.json:
##########
@@ -175,71 +175,71 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByProjects": [ "project-1" ], "isAllowed": true, "isAudited": true,
"policyId": 3001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
},
{
"name": "table: sales.orders, user: proj-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByProjects": [ "project-1" ], "isAllowed": true, "isAudited": true,
"policyId": 3001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
},
{
"name": "table: finance.invoices, user: proj-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByProjects": [ "project-1" ],
"isAllowed": true, "isAudited": true, "policyId": 3001 }
Review Comment:
Extra space after comma following 'datasetIds' or 'projects' arrays. Remove
the extra spaces to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByProjects": [ "project-1" ],
"isAllowed": true, "isAudited": true, "policyId": 3001 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_data_mask.json:
##########
@@ -175,71 +175,71 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByProjects": [ "project-1" ], "isAllowed": true, "isAudited": true,
"policyId": 3001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
},
{
"name": "table: sales.orders, user: proj-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByProjects": [ "project-1" ], "isAllowed": true, "isAudited": true,
"policyId": 3001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
},
{
"name": "table: finance.invoices, user: proj-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByProjects": [ "project-1" ],
"isAllowed": true, "isAudited": true, "policyId": 3001 }
},
{
"name": "table: finance.payments, user: proj-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"payments" } },
"accessType": "select", "user": "proj-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByProjects": [ "project-1" ], "isAllowed": true,
"isAudited": true, "policyId": 3001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByProjects": [ "project-1" ],
"isAllowed": true, "isAudited": true, "policyId": 3001 }
Review Comment:
Extra space after comma following 'datasetIds' or 'projects' arrays. Remove
the extra spaces to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByProjects": [ "project-1" ],
"isAllowed": true, "isAudited": true, "policyId": 3001 }
```
##########
agents-common/src/test/resources/policyengine/gds/test_gds_policy_hive_data_mask.json:
##########
@@ -13,159 +13,159 @@
"resource": { "elements": { "database": "sales", "table":
"prospects" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "column: sales.prospects.channel, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "sales", "table":
"prospects", "column": "channel" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001, "maskType": "MASK_NULL" }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001, "maskType": "MASK_NULL" }
},
{
"name": "table: sales.orders, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders" }
},
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "column: sales.orders.amount, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "sales", "table": "orders",
"column": "amount" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001, "maskType": "CUSTOM", "maskedValue": "-1" }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001, "maskType": "CUSTOM", "maskedValue": "-1" }
},
{
"name": "database: sales, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "sales" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-1" ], "isAllowed": true, "isAudited": true,
"policyId": 2001 }
+ "result": { "datasets": [ "dataset-1" ], "projects": [ "project-1" ],
"datasetIds": [ 1 ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "column: finance.invoices.amount, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices", "column": "amount" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001, "maskType": "CUSTOM", "maskedValue":
"-1" }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001,
"maskType": "CUSTOM", "maskedValue": "-1" }
},
{
"name": "table: finance.invoices, user: ds1-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds1-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1" ], "isAllowed": true,
"isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1" ],
"isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "table: finance.invoices, user: ds2-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"invoices" } },
"accessType": "select", "user": "ds2-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-2" ],
"isAllowed": true, "isAudited": true, "policyId": 2002 }
},
{
"name": "table: finance.payments, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"payments" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "column: finance.payments.amount, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "finance", "table":
"payments", "column": "amount" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001, "maskType": "CUSTOM", "maskedValue":
"-1" }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001,
"maskType": "CUSTOM", "maskedValue": "-1" }
},
{
"name": "database: finance, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "finance" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "allowedByDatasets": [ "dataset-1", "dataset-2" ], "isAllowed":
true, "isAudited": true, "policyId": 2001 }
+ "result": { "datasets": [ "dataset-1", "dataset-2" ], "projects": [
"project-1" ], "datasetIds": [ 1, 2 ], "allowedByDatasets": [ "dataset-1",
"dataset-2" ], "isAllowed": true, "isAudited": true, "policyId": 2001 }
},
{
"name": "table: shipping.shipments, user: ds-user, access: select",
"request": {
"resource": { "elements": { "database": "shipping", "table":
"shipments" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-2" ], "isAllowed": true, "isAudited": true,
"policyId": 2002 }
+ "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"datasetIds": [ 2 ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
},
{
"name": "database: shipping, user: ds-user, access: _any",
"request": {
"resource": { "elements": { "database": "shipping" } },
"accessType": "", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"allowedByDatasets": [ "dataset-2" ], "isAllowed": true, "isAudited": true,
"policyId": 2002 }
+ "result": { "datasets": [ "dataset-2" ], "projects": [ "project-1" ],
"datasetIds": [ 2 ], "allowedByDatasets": [ "dataset-2" ], "isAllowed": true,
"isAudited": true, "policyId": 2002 }
},
{
"name": "table: customers.contact_info, user: ds-user, access:
select",
"request": {
"resource": { "elements": { "database": "customers", "table":
"contact_info" } },
"accessType": "select", "user": "ds-user", "userGroups": []
},
- "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "allowedByDatasets": [ "dataset-3", "dataset-6" ],
"isAllowed": true, "isAudited": true, "policyId": 2003 }
+ "result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3", "dataset-6" ], "isAllowed": true, "isAudited": true, "policyId":
2003 }
Review Comment:
Extra space after comma following 'datasetIds' or 'projects' arrays. Remove
the extra spaces to maintain consistent spacing throughout the JSON file.
```suggestion
"result": { "datasets": [ "dataset-3", "dataset-6" ], "projects": [
"project-2", "project-4" ], "datasetIds": [ 3, 6 ], "allowedByDatasets": [
"dataset-3", "dataset-6" ], "isAllowed": true, "isAudited": true, "policyId":
2003 }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
