kumaab commented on PR #717:
URL: https://github.com/apache/ranger/pull/717#issuecomment-3445981682

   > LGTM overall! πŸ‘
   > 
   > Just one question: **Any specific reason for bumping the timeout to 60 
minutes?** The previous value was 30 min β€” is the Docker build now taking 
significantly longer (e.g. due to larger images, more layers, or slower network 
pulls)? If so, it’d be helpful to add a brief comment in the YAML explaining 
the increase for future maintainers.
   > 
   > Otherwise, feel free to merge!
   
   It seems that the docker build itself is not taking any longer - this is 
similar to earlier runs, but bringing up containers with health checks post 
docker-build might be consuming more time, hence the decision to bump up the 
timeout.
   Yeah, will add a comment on this, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to