mneethiraj commented on code in PR #719:
URL: https://github.com/apache/ranger/pull/719#discussion_r2467633028
##########
dev-support/ranger-docker/Dockerfile.ranger-trino:
##########
@@ -32,42 +32,19 @@ USER root
ARG TRINO_VERSION
ARG TRINO_PLUGIN_VERSION
-ENV PLUGIN_DIR=ranger-${TRINO_PLUGIN_VERSION}-trino-plugin
-RUN mkdir -p /home/ranger/dist /home/ranger/scripts /opt/ranger
+RUN mkdir -p /home/ranger/scripts/
-COPY ./dist/version
/home/ranger/dist
-COPY ./dist/ranger-${TRINO_PLUGIN_VERSION}-trino-plugin.tar.gz
/home/ranger/dist
-COPY ./scripts/ranger-trino.sh
/home/ranger/scripts
-COPY ./scripts/ranger-trino-setup.sh
/home/ranger/scripts
-COPY ./scripts/ranger-trino-plugin-install.properties
/home/ranger/scripts
+COPY ./scripts/access-control.properties /etc/trino/
Review Comment:
Good suggestion. I updated the PR to reflect this suggestion. We should
refactor other config and script files similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
