Copilot commented on code in PR #830:
URL: https://github.com/apache/ranger/pull/830#discussion_r2744031743


##########
agents-common/src/main/resources/service-defs/ranger-servicedef-polaris.json:
##########
@@ -0,0 +1,200 @@
+{
+  "id":          205,
+  "name":        "polaris",
+  "displayName": "Polaris (draft)",
+  "label":       "Apache Polaris",
+  "description": "Apache Polaris",

Review Comment:
   The displayName includes '(draft)' which may be inappropriate for a 
production service definition. Consider removing the draft designation or 
clarifying its purpose in the description field instead.
   ```suggestion
     "displayName": "Polaris",
     "label":       "Apache Polaris",
     "description": "Apache Polaris (draft service definition)",
   ```



##########
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:
##########
@@ -123,6 +124,7 @@ public class EmbeddedServiceDefsUtil {
     private       RangerServiceDef        ozoneServiceDef;
     private       RangerServiceDef        kuduServiceDef;
     private       RangerServiceDef        nestedStructureServiveDef;

Review Comment:
   Corrected spelling of 'nestedStructureServiveDef' to 
'nestedStructureServiceDef'.
   ```suggestion
       private       RangerServiceDef        nestedStructureServiceDef;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to