adoroszlai commented on code in PR #913:
URL: https://github.com/apache/ranger/pull/913#discussion_r3064375683
##########
plugin-ozone/src/test/java/org/apache/ranger/authorization/ozone/authorizer/TestRangerOzoneAuthorizer.java:
##########
@@ -108,10 +108,46 @@ public void testAssumeRoleWithEmptyGrants() throws
Exception {
assertEquals(RangerInlinePolicy.Mode.INLINE, inlinePolicy.getMode());
assertNotNull(inlinePolicy.getGrants());
- RequestContext ctxListWithoutSessionPolicy = new
RequestContext(hostname, ipAddress, user1, OZONE_SERVICE_ID,
IAccessAuthorizer.ACLIdentityType.ANONYMOUS, IAccessAuthorizer.ACLType.LIST,
OWNER_NAME);
- RequestContext ctxReadWithoutSessionPolicy = new
RequestContext(hostname, ipAddress, user1, OZONE_SERVICE_ID,
IAccessAuthorizer.ACLIdentityType.ANONYMOUS, IAccessAuthorizer.ACLType.READ,
OWNER_NAME);
- RequestContext ctxListWithSessionPolicy = new
RequestContext(hostname, ipAddress, user1, OZONE_SERVICE_ID,
IAccessAuthorizer.ACLIdentityType.ANONYMOUS, IAccessAuthorizer.ACLType.LIST,
OWNER_NAME, false, sessionPolicy);
- RequestContext ctxReadWithSessionPolicy = new
RequestContext(hostname, ipAddress, user1, OZONE_SERVICE_ID,
IAccessAuthorizer.ACLIdentityType.ANONYMOUS, IAccessAuthorizer.ACLType.READ,
OWNER_NAME, false, sessionPolicy);
+ RequestContext ctxListWithoutSessionPolicy =
RequestContext.newBuilder()
+ .setHost(hostname)
+ .setIp(ipAddress)
+ .setClientUgi(user1)
+
.setServiceId(OZONE_SERVICE_ID)
+
.setAclType(IAccessAuthorizer.ACLIdentityType.ANONYMOUS)
+
.setAclRights(IAccessAuthorizer.ACLType.LIST)
+ .setOwnerName(OWNER_NAME)
+ .build();
+ RequestContext ctxReadWithoutSessionPolicy =
RequestContext.newBuilder()
+ .setHost(hostname)
+ .setIp(ipAddress)
+ .setClientUgi(user1)
+
.setServiceId(OZONE_SERVICE_ID)
+
.setAclType(IAccessAuthorizer.ACLIdentityType.ANONYMOUS)
+
.setAclRights(IAccessAuthorizer.ACLType.READ)
+ .setOwnerName(OWNER_NAME)
+ .build();
+ RequestContext ctxListWithSessionPolicy =
RequestContext.newBuilder()
+ .setHost(hostname)
+ .setIp(ipAddress)
+ .setClientUgi(user1)
+
.setServiceId(OZONE_SERVICE_ID)
+
.setAclType(IAccessAuthorizer.ACLIdentityType.ANONYMOUS)
+
.setAclRights(IAccessAuthorizer.ACLType.LIST)
+ .setOwnerName(OWNER_NAME)
+
.setRecursiveAccessCheck(false)
+
.setSessionPolicy(sessionPolicy)
+ .build();
+ RequestContext ctxReadWithSessionPolicy =
RequestContext.newBuilder()
+ .setHost(hostname)
+ .setIp(ipAddress)
+ .setClientUgi(user1)
+
.setServiceId(OZONE_SERVICE_ID)
+
.setAclType(IAccessAuthorizer.ACLIdentityType.ANONYMOUS)
+
.setAclRights(IAccessAuthorizer.ACLType.READ)
+ .setOwnerName(OWNER_NAME)
+
.setRecursiveAccessCheck(false)
+
.setSessionPolicy(sessionPolicy)
+ .build();
Review Comment:
- Indentation looks very odd.
- To reduce code duplication, we can create a base builder with the common
properties, and build different `RequestContext` instances with tweaks.
Something like:
```java
RequestContext.Builder builder = RequestContext.newBuilder()
.setHost(hostname)
.setIp(ipAddress)
.setClientUgi(user1)
.setServiceId(OZONE_SERVICE_ID)
.setAclType(IAccessAuthorizer.ACLIdentityType.ANONYMOUS);
RequestContext ctxListWithoutSessionPolicy = builder
.setAclRights(IAccessAuthorizer.ACLType.LIST)
.build();
RequestContext ctxReadWithoutSessionPolicy = builder
.setAclRights(IAccessAuthorizer.ACLType.READ)
.build();
RequestContext ctxListWithSessionPolicy = builder
.setAclRights(IAccessAuthorizer.ACLType.LIST)
.setRecursiveAccessCheck(false)
.setSessionPolicy(sessionPolicy)
.build();
RequestContext ctxReadWithoutSessionPolicy = builder
.setAclRights(IAccessAuthorizer.ACLType.READ)
.setRecursiveAccessCheck(false)
.setSessionPolicy(sessionPolicy)
.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
