mneethiraj commented on code in PR #922:
URL: https://github.com/apache/ranger/pull/922#discussion_r3121962660
##########
dev-support/ranger-docker/scripts/admin/create-ranger-services.py:
##########
@@ -1,8 +1,22 @@
from apache_ranger.model.ranger_service import RangerService
from apache_ranger.client.ranger_client import RangerClient
from json import JSONDecodeError
+import socket
+import os
+import sys
-ranger_client = RangerClient('http://ranger:6080', ('admin', 'rangerR0cks!'))
+skipMe = os.getenv("SKIP_CREATE_SAMPLE_SERVICES","false").lower() == "true"
+
+if skipMe:
+ print("INFO: Skipping sample ranger services ...")
+ sys.exit(0)
+
+current_host_name = socket.gethostname()
+
+if not current_host_name:
+ current_host_name = "ranger"
+
+ranger_client = RangerClient('http://' + current_host_name + ':6080',
('admin', 'rangerR0cks!'))
Review Comment:
Given this script is executed in the container running ranger admin service,
it seem call to `socket.gethostname()` is not necessary; simply using
`localhost` would work, right?
##########
dev-support/ranger-docker/scripts/admin/create-ranger-services.py:
##########
@@ -1,8 +1,22 @@
from apache_ranger.model.ranger_service import RangerService
from apache_ranger.client.ranger_client import RangerClient
from json import JSONDecodeError
+import socket
+import os
+import sys
-ranger_client = RangerClient('http://ranger:6080', ('admin', 'rangerR0cks!'))
+skipMe = os.getenv("SKIP_CREATE_SAMPLE_SERVICES","false").lower() == "true"
Review Comment:
@sneethiraj - for developer testing, I think it is okay to create services
during Ranger admin startup. However, this change would be useful in the
official docker image released to docker hub, which is built from
https://github.com/apache/ranger-tools/tree/main/release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
