pradeepagrawal8184 commented on code in PR #872:
URL: https://github.com/apache/ranger/pull/872#discussion_r3128472106
##########
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java:
##########
@@ -663,7 +663,7 @@ public List<String>
getAllRoleNames(@QueryParam("serviceName") String serviceNam
@Path("/roles/{id}/addUsersAndGroups")
@Consumes("application/json")
@Produces("application/json")
- public RangerRole addUsersAndGroups(@PathParam("id") Long roleId,
List<String> users, List<String> groups, Boolean isAdmin) {
+ public RangerRole addUsersAndGroups(@PathParam("id") Long roleId,
@QueryParam("users") List<String> users, @QueryParam("groups") List<String>
groups, @QueryParam("isAdmin") Boolean isAdmin) {
Review Comment:
Seems resolved, please review again
##########
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java:
##########
@@ -897,7 +897,7 @@ public List<String> getUserRoles(@PathParam("user") String
userName, @Context Ht
@Path("/api/roles/{id}/addUsersAndGroups")
@Consumes("application/json")
@Produces("application/json")
- public RangerRole addUsersAndGroups(@PathParam("id") Long roleId,
List<String> users, List<String> groups, Boolean isAdmin, @Context
HttpServletRequest request) {
+ public RangerRole addUsersAndGroups(@PathParam("id") Long roleId,
@QueryParam("users") List<String> users, @QueryParam("groups") List<String>
groups, @QueryParam("isAdmin") Boolean isAdmin, @Context HttpServletRequest
request) {
return roleREST.addUsersAndGroups(roleId, users, groups, isAdmin);
Review Comment:
Seems resolved, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
