mneethiraj commented on code in PR #926:
URL: https://github.com/apache/ranger/pull/926#discussion_r3140425519
##########
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzConfig.java:
##########
@@ -58,12 +60,19 @@ public Properties getAuditProperties() {
if (propName.startsWith(PROP_PREFIX_AUDIT)) {
String propValue = properties.getProperty(propName);
String propSuffix =
propName.substring(PROP_PREFIX_AUDIT.length());
- String pluginPropName = "xasecure.audit." + propSuffix;
+ String pluginPropName = PROP_PREFIX_XASECURE_AUDIT +
propSuffix;
ret.setProperty(pluginPropName, propValue);
}
}
+ // add legacy audit configurations
+ for (String propName : properties.stringPropertyNames()) {
+ if (propName.startsWith(PROP_PREFIX_XASECURE_AUDIT)) {
Review Comment:
Well, doing so will result in final configuration value of a key to be
dependent on order of keys in the iteration. That will not be correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
