mneethiraj commented on code in PR #936:
URL: https://github.com/apache/ranger/pull/936#discussion_r3209865446
##########
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java:
##########
@@ -1292,12 +1292,16 @@ public void removeSharedResource(@PathParam("id") Long
resourceId) {
@DELETE
@Path("/resources")
@PreAuthorize("@rangerPreAuthSecurityHandler.isAPIAccessible(\"" +
RangerAPIList.REMOVE_SHARED_RESOURCES + "\")")
- public void removeSharedResources(List<Long> resourceIds) {
- LOG.debug("==> GdsREST.removeSharedResources({})", resourceIds);
+ public void removeSharedResources(@QueryParam("resourceIds") List<Long>
resourceIds) {
Review Comment:
@rameeshm - given a separate query parameter will be needed for each
resource, consider naming the query parameter as `resourceId` or `id`. I
suggest `id` as its shorter, hence can handle larger number of resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
