abhiishek26 commented on PR #943: URL: https://github.com/apache/ranger/pull/943#issuecomment-4450255794
> can you add a Junit test if possible ? Hi Vyom I have added the unit tests . The existing unit tests covered most of the scenarios but 1>Earlier the case when json payload and request url ids were not matching but serviceDef name was not blank was getting passed but it should have failed . Unit test testUpdateServiceDefWithValidNameButMismatchedId. handles this case for the changes made . 2> Unit test test2updateServiceDef. was failing with null pointer exception for the changes made , I have modified it to handle the exception correctly . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
