vyommani commented on code in PR #950:
URL: https://github.com/apache/ranger/pull/950#discussion_r3334099772
##########
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java:
##########
@@ -686,31 +704,11 @@ RangerResourceDef getWildcardEnabledResourceDef(String
resourceName, Integer pol
if (policyType == null) {
Review Comment:
The if (policyType == null) condition at line 704 is pre-existing code — our
change only replaced the lazy computeIfAbsent with a simple get.
You are correct that this inconsistency exists, but it is unrelated to the
problem we are solving in this PR. Fixing it here would be scope creep and
risks introducing unintended side effects.
Will raise a separate Jira to track this inconsistency and fix it in a
dedicated PR where it can be properly reviewed and tested in isolation
What do you think about above approach ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
