paras200 commented on code in PR #986: URL: https://github.com/apache/ranger/pull/986#discussion_r3356840985
########## audit-server/audit-dispatcher/dispatcher-common/src/main/java/org/apache/ranger/audit/dispatcher/AuditEventDocMapper.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.ranger.audit.dispatcher; + +import org.apache.ranger.audit.model.AuthzAuditEvent; + +import java.text.DateFormat; +import java.text.SimpleDateFormat; +import java.util.Date; +import java.util.HashMap; +import java.util.Map; +import java.util.TimeZone; + +/** + * Maps {@link AuthzAuditEvent} to an OpenSearch document. + */ +public final class AuditEventDocMapper { + /** Thread-safe ISO-8601 UTC date formatter. */ + private static final ThreadLocal<DateFormat> DATE_FORMAT = + ThreadLocal.withInitial(() -> { + SimpleDateFormat format = new SimpleDateFormat( + "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"); + format.setTimeZone(TimeZone.getTimeZone("UTC")); + return format; + }); + + private AuditEventDocMapper() { + } + + /** + * Converts an audit event to a document map. + * + * @param auditEvent the audit event to convert + * @return map of field names to values + */ + public static Map<String, Object> toDoc( Review Comment: Done — This was the result of running the checkstyle within the code base, now I have removed all multi-line string concatenation splits and unnecessary line breaks across `OpenSearchDispatcherManager`, `AuditOpenSearchDispatcher`, and `AuditEventDocMapper` (now renamed). Also stripped verbose Javadoc comments that didn't add value beyond what the identifiers already communicate. All statements now fit naturally on a single line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
