paras200 commented on code in PR #986: URL: https://github.com/apache/ranger/pull/986#discussion_r3448308317
########## security-admin/scripts/setup.sh: ########## @@ -102,6 +102,13 @@ audit_elasticsearch_user=$(get_prop 'audit_elasticsearch_user' $PROPFILE) audit_elasticsearch_password=$(get_prop 'audit_elasticsearch_password' $PROPFILE) audit_elasticsearch_index=$(get_prop 'audit_elasticsearch_index' $PROPFILE) audit_elasticsearch_bootstrap_enabled=$(get_prop 'audit_elasticsearch_bootstrap_enabled' $PROPFILE) +audit_opensearch_urls=$(get_prop 'audit_opensearch_urls' $PROPFILE) Review Comment: Yes — these follow the same install-time substitution pattern as the existing audit_elasticsearch_* and audit_solr_* properties. setup.sh reads the operator-supplied values (lines 105–111) and writes them into ranger-admin-site.xml when audit_store=opensearch (see lines 877–904). The values shipped in ranger-admin-site.xml are just defaults/placeholders that setup.sh overwrites at install time, so removing them here would make the OpenSearch audit store non-configurable during install. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
