rameeshm commented on code in PR #1154:
URL: https://github.com/apache/ranger/pull/1154#discussion_r3807469452
##########
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java:
##########
@@ -95,6 +95,9 @@ public class SearchFilter {
public static final String SERVICE_NAME_PARTIAL = "serviceNamePartial";
+ public static final String CLIENT_IP = "clientIP";
+ public static final String APP_ID = "appId";
Review Comment:
APP_ID ==> change this to PLUGIN_APP_ID
##########
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java:
##########
@@ -126,6 +153,523 @@ public VXLong getXAccessAuditSearchCount(SearchCriteria
searchCriteria) {
return vXLong;
}
+ public RangerAuditMetrics getLatestAuditMetrics(String serviceType, String
serviceName) {
Review Comment:
Please keep only the main methods in this file and create a new helper class
have the called methods in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
