pradeepagrawal8184 commented on code in PR #1174:
URL: https://github.com/apache/ranger/pull/1174#discussion_r3862273339
##########
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java:
##########
@@ -1177,6 +1177,14 @@ public Collection<String> getRolesByLoginId(String
loginId) {
return roleList;
}
+ public boolean isUserDisabled(String loginId) {
+ if (loginId == null || loginId.trim().isEmpty()) {
+ return false;
+ }
+ XXPortalUser xXPortalUser =
daoManager.getXXPortalUser().findByLoginId(loginId);
+ return xXPortalUser != null && xXPortalUser.getStatus() ==
RangerCommonEnums.STATUS_DISABLED;
Review Comment:
what about changing this to : return xXPortalUser != null &&
xXPortalUser.getStatus() != RangerCommonEnums.ACT_STATUS_ACTIVE;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
