spolavarpau1 commented on code in PR #827: URL: https://github.com/apache/ranger/pull/827#discussion_r3896768690
########## ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java: ########## Review Comment: One minor change, can you please update this if condition to if (config.isDeltaSyncEnabled() && (computeDeletes)) ? That way it is much easier to understand the code. In case of delta sync not enabled, anyway we are performing full sync all the time and not using deltaSyncGroupTime or deltaSyncGroupTimeStamp in the filter. ########## ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java: ########## Review Comment: One minor change, can you please update this if condition to if (!groupUserTable.rowKeySet().isEmpty() || (config.isDeltaSyncEnabled() && (computeDeletes))) ? That way it is much easier to understand the code. In case of delta sync not enabled, anyway we are performing full sync all the time and not using deltaSyncGroupTime or deltaSyncGroupTimeStamp in the filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
