vyommani commented on code in PR #1200: URL: https://github.com/apache/ranger/pull/1200#discussion_r3901343022
########## security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java: ########## @@ -19,12 +19,14 @@ package org.apache.ranger.security.listener; +import javax.servlet.annotation.WebListener; import javax.servlet.http.HttpSession; import javax.servlet.http.HttpSessionEvent; import javax.servlet.http.HttpSessionListener; import java.util.concurrent.CopyOnWriteArrayList; +@WebListener Review Comment: See my comment on `web.xml` — this annotation plus the explicit `<listener>` entry added there for the same class will cause double registration under Tomcat (no `metadata-complete="true"` on `web.xml`), doubling every session-created/destroyed event. Please remove one of the two registration paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
