fimugdha commented on PR #16: URL: https://github.com/apache/ranger-tools/pull/16#issuecomment-5696068529
> Suggestion: to keep this consistent with the existing pattern in this file (`create_users_and_groups(group_name, users)` takes the group first), consider swapping the argument order here: > > ```shell > add_user_to_group "shadow" "ranger" > ``` > > with the function signature updated to `add_user_to_group(groupname, username)` accordingly. @kumaab, Updated the suggested changes in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
