mneethiraj commented on code in PR #1257:
URL: https://github.com/apache/ranger/pull/1257#discussion_r4114001433


##########
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java:
##########
@@ -267,7 +267,12 @@ public void resetUserModulePermission(UserSessionBase 
userSession) {
             List<String> permissionList;
 
             if (userSession.isUserAdmin()) {
-                permissionList = 
daoManager.getXXModuleDef().getAllModuleNames();
+                permissionList = new 
ArrayList<>(daoManager.getXXModuleDef().getAllModuleNames());
+
+                // Config super-users get sys-admin modules only.

Review Comment:
   Shouldn't this be done for all admin users, instead of only for super-user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to