ChinmayHegde24 commented on code in PR #1235:
URL: https://github.com/apache/ranger/pull/1235#discussion_r4281543320
##########
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java:
##########
@@ -383,6 +412,185 @@ public Date getLastSuccessLoginAuthTimeByUserId(String
loginId) {
return null;
}
+ public static boolean isConcurrentSessionExpired(HttpSession session) {
Review Comment:
Nitpick : As per my understanding we follow single return statement per
method convention, so can it be changed to below syntax
boolean ret = false;
if (session != null) {
try {
ret =
Boolean.TRUE.equals(session.getAttribute(SESSION_ATTR_CONCURRENT_EXPIRED));
} catch (IllegalStateException e) {
}
}
return ret;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
